- 26101516_fAVI.jpg (53.24 KiB) 查看 17979 次
这回事由在于Linus认为Mauro违反了内核维护的基本原则。他的原话很好理解：
或许有人觉得Linus的批评太过严厉，但这也正反映出他对Kernel设计、维护原则的坚持，如果没有这种信念，相信Linux很难有今天的地位。希望各位程序员引以为戒！闭上你的臭嘴，Mauro！
这明显是一个bug，Kernel中的bug！你做了多长时间的维护人员了，为什么还不明白Kernel维护的第一原则？
如果修改会导致用户程序的破坏，那问题一定是在Kernel上！永远不可以归咎用户程序的责任，学会这点真的很难吗？
更糟糕的是，commit f0ed2ce840b3虽然并没有破坏程序，但它完全是废话。
……
永远不可以破坏USERSPACE！
http://thread.gmane.org/gmane.linux.ker ... us=1414106
来源：oschinaFrom: Linus Torvalds <torvalds <at> linux-foundation.org>
Subject: Re: [Regression w/ patch] Media commit causes user space to misbahave (was: Re: Linux 3.8-rc1)
Newsgroups: gmane.linux.kernel
Date: 2012-12-23 17:36:15 GMT (1 day, 17 hours and 45 minutes ago)
On Sun, Dec 23, 2012 at 6:08 AM, Mauro Carvalho Chehab
<mchehab <at> redhat.com> wrote:
>
> Are you saying that pulseaudio is entering on some weird loop if the
> returned value is not -EINVAL? That seems a bug at pulseaudio.
Mauro, SHUT THE 囗囗囗囗 UP!
It's a bug alright - in the kernel. How long have you been a
maintainer? And you *still* haven't learnt the first rule of kernel
maintenance?
If a change results in user programs breaking, it's a bug in the
kernel. We never EVER blame the user programs. How hard can this be to
understand?
To make matters worse, commit f0ed2ce840b3 is clearly total and utter
CRAP even if it didn't break applications. ENOENT is not a valid error
return from an ioctl. Never has been, never will be. ENOENT means "No
such file and directory", and is for path operations. ioctl's are done
on files that have already been opened, there's no way in hell that
ENOENT would ever be valid.
> So, on a first glance, this doesn't sound like a regression,
> but, instead, it looks tha pulseaudio/tumbleweed has some serious
> bugs and/or regressions.
Shut up, Mauro. And I don't _ever_ want to hear that kind of obvious
garbage and idiocy from a kernel maintainer again. Seriously.
I'd wait for Rafael's patch to go through you, but I have another
error report in my mailbox of all KDE media applications being broken
by v3.8-rc1, and I bet it's the same kernel bug. And you've shown
yourself to not be competent in this issue, so I'll apply it directly
and immediately myself.
WE DO NOT BREAK USERSPACE!
Seriously. How hard is this rule to understand? We particularly don't
break user space with TOTAL CRAP. I'm angry, because your whole email
was so _horribly_ wrong, and the patch that broke things was so
obviously crap. The whole patch is incredibly broken 囗囗囗囗. It adds an
insane error code (ENOENT), and then because it's so insane, it adds a
few places to fix it up ("ret == -ENOENT ? -EINVAL : ret").
The fact that you then try to make *excuses* for breaking user space,
and blaming some external program that *used* to work, is just
shameful. It's not how we work.
Fix your f*cking "compliance tool", because it is obviously broken.
And fix your approach to kernel programming.
Linus
